From 2e6d69ddc76bcd38f4bf1f02a4c468e95032d3c9 Mon Sep 17 00:00:00 2001 From: Erik Date: Sat, 15 Aug 2026 11:51:57 +0200 Subject: [PATCH] docs: file #400 (Credits -> gmCreditsUI, post-LA) and fix the misfiled comment The ef96c554 batch ghosted Credits with a comment claiming it was filed as #397 - that number is the Windows graceful-stop issue and no Credits entry existed. #400 now records the gap properly. Co-Authored-By: Claude Fable 5 --- docs/ISSUES.md | 19 +++++++++++++++++++ .../Layout/CharacterManagementUiController.cs | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/docs/ISSUES.md b/docs/ISSUES.md index 2559c242..f33e559f 100644 --- a/docs/ISSUES.md +++ b/docs/ISSUES.md @@ -24,6 +24,25 @@ What does NOT go here: - Every session: scan OPEN issues at start; promote/close anything we touched during the session before ending. - Promoting to a Phase: mark as `DONE (promoted to Phase X)` + commit SHA where the Phase entry landed. +## #400 — Character select: Credits button is ghosted; retail opens gmCreditsUI + +**Status:** OPEN (post-LA polish) +**Severity:** LOW +**Filed:** 2026-08-15 (Campaign LA gate round 2, char-select findings batch) +**Component:** `src/AcDream.App/UI/Layout/CharacterManagementUiController.cs` + +Retail's character-management screen routes the Credits button +(`0x100003A3`, listbox-base offset 6 in +`gmCharacterManagementUI::ListenToElementMessage @0x004ed5a0`) to +`QueueUIMode(0x10000005)` → `gmCreditsUI` (`Register @0x0047a69e`) — a +scrolling credits screen. acdream ghosts the button (visible, disabled, +no invented action — the same treatment as Create Character). Porting +`gmCreditsUI` is its own small screen (authored layout, scroll behavior, +return-to-select) and is deliberately out of Campaign LA's scope. + +**Acceptance:** Credits opens the ported retail credits screen and +returns to character select; button re-enabled. + ## #399 — Launcher: no test ever constructs MainWindow, so code-behind defects reach the user gate **Status:** DONE (this commit, Campaign LA UI-test slice) — closed via diff --git a/src/AcDream.App/UI/Layout/CharacterManagementUiController.cs b/src/AcDream.App/UI/Layout/CharacterManagementUiController.cs index eb2c7c8c..c9c5b4a3 100644 --- a/src/AcDream.App/UI/Layout/CharacterManagementUiController.cs +++ b/src/AcDream.App/UI/Layout/CharacterManagementUiController.cs @@ -134,7 +134,7 @@ internal sealed class CharacterManagementUiController : IDisposable // Credits (retail QueueUIMode(0x10000005) -> gmCreditsUI) is out of // scope this round (finding 1 note) — same "future campaign, visibly // ghosted, no invented action" treatment as Create above. Filed as - // issue #397. + // issue #400. _credits.Visible = true; _credits.Enabled = false; _credits.OnClick = null;