erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix(ui): assess retained items on right click

Browse source 
Port UIElement_ItemList's physical-item right-click branch through the shared retained list. Select and appraise backpack, loot, paperdoll, and shortcut items through their canonical owners, while preventing RMB movement from lifting items or issuing appraisal requests.

Co-authored-by: Codex <codex@openai.com>
This commit is contained in:
Erik 2026-07-24 05:55:51 +02:00
parent 5ad32d5753
commit 2dd5cb80d2
17 changed files with 264 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/AcDream.App.Tests/UI/Layout/ExternalContainerControllerTests.cs
View file

@ -57,6 +57,7 @@ public sealed class ExternalContainerControllerTests
public readonly List<uint> Uses = new();
public readonly List<uint> NoLonger = new();
public readonly List<uint> Pickups = new();
public readonly List<uint> Examines = new();
public readonly List<(uint Item, uint Container, int Placement)> Puts = new();
public readonly List<(uint Item, uint Container, uint Placement, uint Amount)> Splits = new();
public readonly UiRoot Screen = new() { Width = 800f, Height = 600f };
@ -110,6 +111,7 @@ public sealed class ExternalContainerControllerTests
sendUseWithTarget: null,
sendWield: null,
sendDrop: null,
sendExamine: Examines.Add,
groundObjectId: () => State.CurrentContainerId,
placeInBackpack: (item, _, _) => Pickups.Add(item),
sendPutItemInContainer: (item, container, placement) =>
@ -183,6 +185,20 @@ public sealed class ExternalContainerControllerTests
Assert.Equal(new uint[] { Item }, h.Pickups);
}
[Fact]
public void RightClickLoot_selectsAndExaminesWithoutPickingUp()
{
using var h = new Harness();
h.Open(Chest, new ContainerContentEntry(Item, 0u));
UiItemSlot cell = h.Contents.GetItem(0)!;
cell.OnEvent(new UiEvent(0u, cell, UiEventType.RightClick));
Assert.Equal(Item, h.Selection.SelectedObjectId);
Assert.Equal(new uint[] { Item }, h.Examines);
Assert.Empty(h.Pickups);
}
[Fact]
public void CloseAndRangeExit_SendUseOnceWithoutNoLongerViewing()
{