erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(phys): #112 - remove the non-retail escape-hatch demote from the pick; lateral stab-graph recovery + retail keep-curr

Browse source 
Root cause (oracle: CLandCell::point_in_cell :316941 = terrain-poly only;
find_cell_list null-result keep-curr pc:308788-308825; CEnvCell::
check_building_transit :309827 = sphere_intersects_cell per portal-adjacent
cell): retail KEEPS curr_cell when nothing contains the centre — including
inside a house's containment gaps. Our 6dbbf95 escape hatch instead demoted
any hydrated indoor claim the sphere no longer overlaps to the outdoor
column; at the A9B3 hill cottage's real interior gap this stranded the
player outdoor-classified deep indoors, where re-promotion is portal-
adjacent-only (retail-identical) -> the outdoor flood rendered the interior
transparent (the user's "sometimes transparent" walk).

The hatch's actual target - poisoned (cell, position) SAVES - has been
handled at the SNAP by PhysicsEngine.Resolve's AdjustPosition validation
since #107/#111, so the per-tick pick reverts to retail semantics:
1. lateral recovery first - when the sphere no longer overlaps the claim,
   search the claim's stab list for a containing cell (retail
   find_visible_child_cell :311444, the same recovery AdjustPosition uses);
   the #111 adjacent-claim shape now self-heals laterally (dat-backed test:
   pick(seed 0x172) at a 0x171-interior point -> 0x171);
2. else KEEP curr_cell (retail null-result).

Two old tests asserting the hatch demote rewritten to the retail semantics
(tests-can-codify-bugs); P1 retail-golden conformance gates explicitly green
(FindCellListConformance + ThresholdPortalCrossing + CottageDoorway +
CameraCornerSeal = 11/11). New Issue112MembershipTests: the lateral-recovery
fact + a DocumentsResidual fact pinning the remaining at-doorway gap demote
(via the NORMAL outdoor-candidate path; open oracle read = retail's
add_all_outside_cells gate in CEnvCell::find_transit_cells pc:317499 -
sphere-proximity vs graph-reachability). Core 1383 + 4 pre-existing #99
failures + 1 skip.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-06-10 15:03:49 +02:00
parent e9c8a925d2
commit 2d6954ee44
4 changed files with 133 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/AcDream.Core.Tests/Conformance/Issue107SpawnDiagnosticTests.cs
View file

@ -75,13 +75,15 @@ public sealed class Issue107SpawnDiagnosticTests
_out.WriteLine($"FindCellList(seed=0x{ActualCell:X8}) -> 0x{pickGood:X8}");
Assert.Equal(ActualCell, pickGood);
// Production pick with the POISONED seed demotes to the outdoor column —
// retail-identical for a cross-building claim (0x171 is not in 0x162's
// stab list). The login-side fix is AdjustPosition at the snap, which
// demotes IMMEDIATELY instead of after the first movement.
// Production pick with the POISONED seed KEEPS it — retail's
// find_cell_list null-result behavior (pc:308788-308825; #112 removed
// the non-retail escape-hatch demote that used to return the outdoor
// column here). The poisoned-save case is handled at the SNAP:
// PhysicsEngine.Resolve's AdjustPosition validation rejects the claim
// and demotes via seen_outside BEFORE physics ever runs on it.
uint pickBad = CellTransit.FindCellList(cache, footCenter, FootRadius, PoisonedClaim);
_out.WriteLine($"FindCellList(seed=0x{PoisonedClaim:X8}) -> 0x{pickBad:X8}");
Assert.Equal(0xA9B40031u, pickBad);
Assert.Equal(PoisonedClaim, pickBad);
}
[Fact]