erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(net): sign-extend retail capacity bytes

Browse source 
Mirror PublicWeenieDesc::UnPack MOVSX behavior so ACE's FF capacity sentinels remain -1 instead of becoming 255. This suppresses non-container capacity prose through the normal retail appraisal checks, with raw-wire and formatter regression coverage.

Co-authored-by: Codex <codex@openai.com>
This commit is contained in:
Erik 2026-07-23 18:25:17 +02:00
parent d3c5e06fdd
commit 2c00d53db2
7 changed files with 101 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

14
docs/research/2026-07-23-retail-appraisal-ui-pseudocode.md
View file

@ -363,14 +363,24 @@ IsHook(object):
return PublicWeenieDesc.HookType != 0
and PublicWeenieDesc.HookItemTypes != TYPE_UNDEF
UnpackCapacityByte(wireByte):
# PublicWeenieDesc::UnPack uses MOVSX at 0x005AD530 and 0x005AD545.
# The generated pseudocode's uint8_t temporary is misleading.
return sign_extend_int8_to_int32(wireByte)
ShowCapacity(object, profile):
if object is not a hook or profile does not contain a HookProfile:
append authored item/container capacity as a new paragraph
if profile contains PageCount (175) and PageUsed (174):
append "<used> of <count> pages full." as a new paragraph
# A hook with a HookProfile describes its mounted item. Its sentinel
# 255/255 PublicWeenieDesc capacities are not player-facing capacity.
# A hook with a HookProfile describes its mounted item, so the hook's own
# capacity is not player-facing capacity.
# Ordinary creature/NPC-lookalike templates can carry -1/-1 capacity
# sentinels. They travel as FF/FF but UnpackCapacityByte restores -1/-1,
# so the routine's > 0 tests emit no capacity prose. Black Phyntos Hive
# (WCID 28249) is this case: Creature, not Hook.
ShowLock(object, profile):
if object is a hook:

4
docs/research/deepdives/r06-items-inventory.md
View file

@ -411,8 +411,8 @@ if (Behavior & 0x04000000 IncludesSecondHeader):
Per-flag (in exact order):
0x00000001 PluralName : WString16L
0x00000002 ItemsCapacity : byte
0x00000004 ContainersCapacity: byte
0x00000002 ItemsCapacity : int8, sign-extended to int32
0x00000004 ContainersCapacity: int8, sign-extended to int32
0x00000100 AmmoType : uint16
0x00000008 Value : uint32
0x00000010 Usable : uint32 (Usable enum)