diff --git a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md index 39a2df58..96814a03 100644 --- a/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md +++ b/docs/plans/2026-09-01-campaign-overhaul-world-solidity.md @@ -695,8 +695,8 @@ Update immediately when a slice changes state. Chat is not the ledger. | S5-c4 | **LANDED + REVIEW-CLOSED 2026-09-05; LEAD GRAPHICAL GATE PROVISIONAL PASS.** Campaign stack `75664805f` -> `15ed57a1e` -> `d5cfd1c91` -> `03a108ffa`; reviewed scratch tip `db8136448`; packet §§22–26. | G4 UNPASSED | Retail/material pass 3/10 PASS. Full production pass 4/10 found one classic/private detail-off regression; fix round 3 restored the prior AlphaBlend/coalescing path, and narrow production pass 5/10 PASS reproduced all three mutations. Fresh campaign Release 0W/0E, App 245/245, Content 71/71; scratch hermetic 16,971/16,971 and InstalledDat 469/10/1 with both manifests 32/32. Full recipe-10 bake: 2,237,865 keys, zero failures, SHA `4E0FA6C5…29B59B`. Gate `logs/selfgate-20260905-020703-s5c4-onepass-detail`: 13/13 PNGs, exit 0, graceful, no client left; visual PASS provisional. #471 DONE; #470 narrowed to local-sidecar indexing. | | S5-#470 | **LANDED + REVIEW-CLOSED 2026-09-05; LEAD GRAPHICAL A/B PROVISIONAL PASS.** Campaign implementation stack `15a796c3a` -> `7506e5f14` -> `b333edb4f`; route `19b44e5e3`; reviewed scratch `51f974da4` -> `2cad9c84` -> `98c004aa7`; packet §§27–30. | G4 UNPASSED | Retail/behavior pass 2/10 and production pass 4/10 closed the two evidence-only findings. Fresh campaign Release 0W/0E and focused 48/48; exact scratch hermetic 16,976/16,976 and canonical InstalledDat 386/10/1, manifests 30/30. Pinned gate `logs/selfgate-20260905-032132-s5-470-pinned-shadow-ab-r1`: retail/off -> High -> retail/off, 3/3 PNGs, exit 0, graceful, no client; visual PASS provisional. The stale recipe-8 pre-route launch is excluded and recorded in §30. | | S5-#469 | **LANDED + REVIEW-CLOSED 2026-09-05; LEAD GRAPHICAL TRANSITION PROVISIONAL PASS.** Contract `809887524`; reviewed scratch `c09b6cf0f`; campaign implementation `94ddde69a`; route `62efc72cb`; packet §§31–32. | G4 UNPASSED | Retail/deviation pass 1/10 and production pass 2/10 both PASS with no finding. The two atmospheric vertex receivers keep retail's authored unnormalized `uLights` direction across every shadow gate; celestial direction remains for opt-in shadow/volumetric projection; IA-24 corrected in the same commit. Exact scratch: Release 0W/0E, focused 126/126, Vulkan 2/2, hermetic 16,983/16,983, InstalledDat 386/10/1. Fresh campaign Release 0W/0E, focused 82/82, Vulkan 2/2. Gate `logs/selfgate-20260905-040449-s5-469-lighting-transition-r1`: five PNGs, active 2,500-caster/four-cascade High rows, no near-black relight, exit 0/graceful, no client; visual PASS provisional. | -| S5-c5 | **CONTRACTED 2026-09-05; implementation next.** Packet §33. | G4 UNPASSED | Delete the callerless portal-BFS/research types, obsolete renderer probes and hidden scratch/call sites; preserve the one typed walk transcript; correct architecture/register/launch-option truth; add guards for one graph owner, no frame-time DAT dependency, no independent visibility builder, order-preserving submission, and absence of deleted diagnostics. | -| S5 | IN FLIGHT — c1–c4 plus #470/#469 landed, review-closed, and provisionally self-gated; c5 contracted; closeout and G4 remain | G4 | Packet §§7 and 12–33 are binding. Next: implement/review/self-gate c5, then closeout and G4. Never merge main before G4. | +| S5-c5 | **CLOSED + LANDED 2026-09-05; LEAD GRAPHICAL SMOKE PROVISIONAL PASS.** Contract `b77989c32`; campaign `bf53e2ad6` -> `e625dc4e6` -> `1b7ee4e58`; reviewed scratch tip `158656f0d`; packet §§33–35. | G4 UNPASSED | Retail/deletion pass 1/10 PASS. Production pass 2/10 found one static-field hole in the owner guard; fix round 1 reproduced both static-owner mutations, and production pass 3/10 PASS. Exact scratch hermetic 16,921/16,921, canonical InstalledDat 368/9/1, manifests 30/30. Fresh campaign Release 0W/0E, App 146/146, Core 8/8. A stale recipe-8 preflight is excluded; a non-destructive recipe-10 bake produced 2,237,865 keys with zero failures. Corrected gate `logs/selfgate-20260905-052130-s5-c5-landed-v10`: five PNGs, exit 0/graceful, no fatal/deleted-prefix match, no client left; geometry matches S5-c4, visual PASS provisional. | +| S5 | IN FLIGHT — c1–c5 plus #470/#469 landed, review-closed, and provisionally self-gated; automated/performance closeout and G4 remain | G4 | Packet §§7 and 12–35 are binding. Next: execute the full closeout, then G4. Never merge main before G4. | --- diff --git a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md index 1c983e20..1257217d 100644 --- a/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md +++ b/docs/research/2026-09-01-overhaul/s5-consumers-material-closeout-packet.md @@ -3196,3 +3196,70 @@ The InstalledDat nonpassing identities must remain the accepted nine failures plus one look-in skip. Production/gate-honesty review then resumes as pass 3/10; the already-passed retail/deletion lens is not repeated because this round changes no production or retail claim. + +## 35. S5-c5 landing, review closeout, and lead graphical smoke — 2026-09-05 + +**CLOSED AND LANDED; GRAPHICAL PASS IS PROVISIONAL PENDING OWNER +INSPECTION.** The reviewed implementation stack in `s5-c5-openai-impl` is +`36bea55f337c010683263a2eb315514c47121e9f` -> +`2886091aa92f62ceec8c16d4fd5b2dd6056eb5b8` -> +`158656f0df3edd5e28ac3a9ed743f4c435e321f9`. It maps to the campaign stack +`bf53e2ad6` -> `e625dc4e6` -> `1b7ee4e58` on top of contract +`b77989c32`. The final campaign commit is +`1b7ee4e58100b27a55063e0bd462f54c589b1d7e`. + +The deletion removes the callerless portal-BFS research graph and its tests, +the complete Facility-stair instrumentation family, the obsolete renderer +probe/output branches and hidden scratch, and the raw-GL diagnostic reader. +The live `RetailFrameWalk`/`WalkFrameDriver`, `BeginWalkFrame`, outside-view +reassembly, two FIFO lists/router/material/shader paths, typed walk transcript, +frame profiler, terrain diagnostics, and +`UnregisteredRenderMembershipCount` remain. Architecture and inventory now +state one production graph; AP-19 is retired, AD-116 is amended, and +AP-238--AP-243 remain active. + +Sequential review closed in three passes. Retail/deletion pass 1/10 returned +PASS with no finding after independently rechecking the named functions and +the paired binary/PDB identity. Production/gate-honesty pass 2/10 found one +MINOR test-only non-vacuity hole: the unique-owner reflection scan omitted +static fields. Fix round 1 added `BindingFlags.Static`. The lead reproduced +both required static-owner mutations and their intended first failures, then +restored them exactly. Production re-review pass 3/10 returned PASS with no +remaining finding; the production source tree was unchanged by the fix. + +Exact reviewed-tip evidence is hermetic 16,921 passed / 0 failed / 0 skipped, +canonical InstalledDat 368 passed / the accepted nine failures / one accepted +look-in skip, and both manifests 30/30. Fresh campaign-tip verification passed +Release at 0 warnings / 0 errors, App focused 146/146, and Core focused 8/8. +The campaign tree was clean before the graphical gate. + +The first smoke attempt is excluded as environment preflight evidence. It +opened the default machine-local `acdream.pak`, rejected recipe 8 against the +recipe-10 client, emitted no PNG, exited with the .NET unhandled-exception code, +and left no client. Log: +`logs/selfgate-20260905-051948-s5-c5-landed`. No renderer assertion was +reached. The lead then ran the repository's validated transactional bake to a +new path, leaving the recipe-8 package untouched. Recipe-10 output: +2,237,865 keys, zero failures, 597,482,264 bytes, SHA-256 +`4E0FA6C589ECE12E13099A56385077964961EC52F888BC9161C6F5D34829B59B`. + +The one corrected smoke run began with ACE listening on UDP 9000, zero client +processes, a clean campaign tree, and the already-green Release binary. It ran +`tools/overhaul-selfgate/route.txt` once against the new package, exited 0, +confirmed graceful logout, and left zero client processes. The log contains no +crash, invariant failure, device-loss/screenshot failure, or deleted probe +prefix. Exact evidence root: +`logs/selfgate-20260905-052130-s5-c5-landed-v10`. PNGs: + +- `artifacts/screenshots/00-login.png`; +- `artifacts/screenshots/01-cathedral-stairs.png`; +- `artifacts/screenshots/02-facility-stairs.png`; +- `artifacts/screenshots/03-holtburg-house.png`; and +- `artifacts/screenshots/04-holtburg-terrain-leak.png`. + +Lead original-resolution inspection and comparison with +`logs/selfgate-20260905-020703-s5c4-onepass-detail` found the same intact +cathedral, Facility, house-portal, and outdoor-terrain geometry; only authored +time/weather changed. Verdict: **PASS, provisional until the owner inspects +the PNGs.** S5-c5 is closed. S5 automated/performance closeout and G4 remain; +never merge to `main` before G4.