erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs(issues): #423 - ray/shadow/volumetric day-group policy keys on the raw index, not WeatherKind

Browse source 
Found at the VM6 spot-check; pre-existing from Campaign AR; values were
owner-accepted so it is filed for its own gate rather than changed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-23 01:08:32 +02:00
parent 6cc5e183b9
commit 27a446f05c
1 changed files with 22 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

22
docs/ISSUES.md
View file

@ -24,6 +24,28 @@ What does NOT go here:
- Every session: scan OPEN issues at start; promote/close anything we touched during the session before ending.
- Promoting to a Phase: mark as `DONE (promoted to Phase X)` + commit SHA where the Phase entry landed.
## #423 — Atmospheric ray/shadow/volumetric day-group policy keys on the raw day-group index, not the DAT-classified WeatherKind
**Status:** OPEN — filed 2026-08-23 at Campaign VM VM6 (spot-check); pre-existing from Campaign AR.
**Component:** rendering / render packs — atmosphere policy
**Description:** `BuiltInAtmosphericRenderPack.AtmospherePolicy()` declares
`ActiveDayGroupMultiplier(0, 1.0), (1, 0.35), (2, 0.20)` and
`AtmosphericPostProcessGraph.EvaluateDayGroupPolicy` applies it to sun-ray,
directional-shadow and volumetric strength by the raw `activeDayGroup`
INDEX, with an undocumented assumed meaning (0 = brightest … 2 = dimmest).
Dereth's day-group index carries no weather meaning; the codebase classifies
the group's DAT name into `AcDream.Core.World.WeatherKind` (Clear/Overcast/
Rain/Snow/Storm, `WeatherState.cs:198-232`), which `DirectionalShadowQuality`
already keys on. VM6's foliage wind was corrected to `WeatherKind` at
`6cc5e183`; the ray/shadow/volumetric multiplier was left as-is because the
owner accepted its look at the Stage-1 gate and re-keying changes it.
**What to do:** re-declare as `WeatherKind`-keyed points (same shape as
`FoliageWindByWeather`), choose the per-kind multipliers at an owner visual
gate, and retire `ActiveDayGroupMultiplier`. Validator must reject unknown
kinds. Same class as the VM6 fix; do not guess the values.
## #422 — Intermittent heap-corruption exit (0xC0000374) after a pack-on offline capture
**Status:** OPEN — filed 2026-08-22 at Campaign VM VM3; VM7 gate item (fix or characterise before merge).