fix(ui): #409 tooltip review fix round — F1-F11
Opus review of a377b9bf returned architectural PASS-with-findings /
retail-fidelity FAIL with F1-F12 (F12 info-only). All eleven fixed,
each re-derived against docs/research/named-retail/acclient_2013_pseudo_c.txt:
- F1 PositionAtMouse: retail offsets BOTH axes +32px before the clamp
(StartTooltip @0x00459700, @0x00459739/@0x00459747) — was landing
flush at the cursor.
- F2 UiRoot: the dwell timer now anchors to mouse-IDLE like retail's
m_lastMouseMoveTime (MouseMoveHandler @0x0045E710), resetting on
every move within the same widget while !_tooltipFired, not just on
hover-enter.
- F3 register TS-85 rewritten: the "dynamic InqProperty(0x49) override"
framing was false — UIElement::InqProperty @0x004638D0's base impl
reads the same authored bags this port already reads. The real
second text source (m_TTText/SetTooltip, headed by the P0xD0
truncated-text auto-tooltip @0x00466F80) needs a per-line-position
truncation model UiText doesn't have — sized disproportionate for
this round and left honestly deferred rather than stubbed.
- F4 OnTooltipShow: null LayoutPolicy + Anchors=None on the popup root
and text child before resizing, mirroring RetailMessageDialogView's
sibling shape.
- F5 OnTooltipShow: return without mounting when the P0x4A text child
doesn't resolve to a UiText (retail's DynamicCast gate,
StartTooltip @0x0045DE90 @0x0045df65/@0x0045df6f) — was mounting an
empty 30x30 bevel artifact.
- F6 UiRoot.Tick: the dwell-arm branch now requires Captured is null
(CheckTooltip @0x0045B6E0 @0x0045b715) — a widget hovered before a
drag/resize/capture began must not pop mid-gesture.
- F7 UiRoot.ReleaseCapture: no longer resets _tooltipFired
(ReleaseMouseCapture @0x0045D2B0 touches only the idle timestamp) —
a mouse-up while a tooltip is shown no longer tears it down and
silently re-fires it 250ms later.
- F8 ApplyTooltipText: applies ResizeTo's own max/min width/height
clamps (P0x3C/0x3D/0x3E/0x3F, @0x00463C30) before assigning the
grown size; zeroes text.Padding to keep the measured size margin-
comparable. New ElementInfo/UiElement plumbing for the four
properties, same shape as the existing tooltip fields.
- F9 doc precision: sweep counts corrected 434->430 / 191->187 (live-
DAT re-measured), the "243 showable" claim now measured exactly
(not assumed) via a new Showable column in the sweep test, and the
MiscSettings citation split into its two real mechanisms
(RegisterPreference in Init vs. AttachPreference/SetPreferenceRange
elsewhere).
- F10 register AD-106: the topmost guarantee is versus dialogs/screens
only (the overlay popup layer and drag ghost still paint above
regardless), and the per-tick BringToFront ratchet has four rungs,
not three.
- F11 RetailUiRuntime.ResetSessionDialogs: now also calls the new
UiRoot.ResetTooltipTracking() so a post-reset hover re-shows
immediately instead of waiting out the stale fired-latch.
New pinning tests (RetailTooltipPresenterTests: F1/F2/F5/F6/F7/F8) each
verified to fail against the pre-fix behavior via a temporary revert-
and-rerun before being confirmed against the restored fix.
PortalProjectionTests.ProjectToClipLease_ReusesPooledWorkWithoutResultArrays
recurrence logged on issue #346 (already the tracking issue for this
load-sensitive flake) — hit twice under load this review, standalone
26/26, unrelated to #409.
Gates: Release build 0 errors; App suite (live-DAT env) 5416/5413
passed/3 skips (was 5410/5407/3, +6 new tests); Runtime 1735/0;
UI.Abstractions 926/0; full solution (no env, 69 skips expected)
14,623/14,554 passed/69 skipped/0 failed (was 14,617/14,548, +6).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
a377b9bff7
commit
2719782dc0
11 changed files with 515 additions and 58 deletions
|
|
@ -2,19 +2,29 @@ namespace AcDream.UI.Abstractions.Panels.Settings;
|
|||
|
||||
/// <summary>
|
||||
/// #409 (client-wide retail tooltip system): the two <c>Misc.*</c>
|
||||
/// <c>UserPreferences.ini</c> keys retail's <c>UIElementManager::Init
|
||||
/// @0x0045EE10</c> registers (<c>UIPreferences::AttachPreference</c>,
|
||||
/// <c>Misc_TooltipDelay</c>/<c>Misc_TooltipEnable</c>) and binds onto
|
||||
/// <c>UIElementManager::m_tooltipDelay</c>/<c>m_tooltipEnable</c>. These are
|
||||
/// CLIENT-LOCAL preferences, not part of the server-synced
|
||||
/// <c>CharacterOptionTable</c> — the #409 investigation confirmed retail's
|
||||
/// own 2013 Config tab does not expose a visible row for either (they exist
|
||||
/// in <c>UserPreferences.ini</c> and are registered engine-side, but
|
||||
/// <c>gmConfigUI::InitOptions</c>'s 27 authored rows never author one), so
|
||||
/// this record follows the <see cref="CameraTurningSettings"/>/
|
||||
/// <see cref="AudioSettings"/> client-local persistence precedent WITHOUT a
|
||||
/// matching options-panel row — persisted, but not (yet) user-editable
|
||||
/// in-client, exactly matching what retail itself ships.
|
||||
/// <c>UserPreferences.ini</c> keys, <c>Misc_TooltipDelay</c>/
|
||||
/// <c>Misc_TooltipEnable</c>. F9 correction (2026-08-16 review round): two
|
||||
/// DISTINCT retail mechanisms touch these, not one —
|
||||
/// <c>UIElementManager::Init @0x0045EE10</c> calls
|
||||
/// <c>UserPreferences::RegisterPreference</c> (<c>@0x0045EE41</c> for
|
||||
/// <c>Misc_TooltipDelay</c>, <c>@0x0045EE92</c> for
|
||||
/// <c>Misc_TooltipEnable</c>) to bind the LIVE runtime variables
|
||||
/// (<c>UIElementManager::m_tooltipDelay</c>/<c>m_tooltipEnable</c>) to their
|
||||
/// named preference with a change callback; a SEPARATE preference-metadata
|
||||
/// table builder (containing <c>@0x00403811</c>-<c>@0x0040384E</c>) calls
|
||||
/// <c>UIPreferences::AttachPreference</c> (declaring the name/kind/help-text
|
||||
/// hash) and, for the float, <c>UIPreferences::SetPreferenceRange</c>
|
||||
/// (<c>@0x00403821</c>, the <c>[0,10]</c> clamp). These are CLIENT-LOCAL
|
||||
/// preferences, not part of the server-synced <c>CharacterOptionTable</c> —
|
||||
/// the #409 investigation confirmed retail's own 2013 Config tab does not
|
||||
/// expose a visible row for either (they are attached to the global
|
||||
/// preference registry, but <c>gmConfigUI::InitOptions</c>'s 27 authored
|
||||
/// rows — a DIFFERENT, later function that decides which attached
|
||||
/// preferences actually get a widget — never author one), so this record
|
||||
/// follows the <see cref="CameraTurningSettings"/>/<see cref="AudioSettings"/>
|
||||
/// client-local persistence precedent WITHOUT a matching options-panel row —
|
||||
/// persisted, but not (yet) user-editable in-client, exactly matching what
|
||||
/// retail itself ships.
|
||||
/// </summary>
|
||||
public sealed record MiscSettings(
|
||||
bool TooltipEnable,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue