docs: CC6b-PRE re-review residuals R1/R2 + cross-branch renumbering
R1: the unsound elided-ctor-byte argument survived at its canonical citation site (ChargenPreviewEntityBuilder's class doc, which the two corrected docs point at) and in the ledger row's Deliverables column, which contradicted its own review-status column. Both now carry the real evidence: InitializePage @0x0047FDD0 writes an explicit m_bZoomedIn = 0 at 0x004802C3. R2: the verified 180-degree initial heading (m_fCurHeading = 180f at 0x00480235 + SetPlayerHeading at 0x0048023F, cross-confirmed at gmBarberUI::PostInit and the summary page) now has a durable home in the CC6b-mount OWED list — without it the mount half ships a character facing away from the camera. Merge prep: the branch-local TS-82 renumbered to TS-84 (the CC4 branch independently allocated TS-82 and landed first) and the branch-local ISSUES #402 renumbered to #403 (same collision, same rule), with the Core doc reference updated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
1ba22a01a8
commit
2388fe7aa7
5 changed files with 16 additions and 14 deletions
|
|
@ -24,7 +24,7 @@ What does NOT go here:
|
|||
- Every session: scan OPEN issues at start; promote/close anything we touched during the session before ending.
|
||||
- Promoting to a Phase: mark as `DONE (promoted to Phase X)` + commit SHA where the Phase entry landed.
|
||||
|
||||
## #402 — Consolidate RetailAnimationCyclePlayback into LiveEntityAnimationPresenter's legacy branch
|
||||
## #403 — Consolidate RetailAnimationCyclePlayback into LiveEntityAnimationPresenter's legacy branch
|
||||
|
||||
**Status:** OPEN (post-CC consolidation follow-up)
|
||||
**Severity:** LOW
|
||||
|
|
|
|||
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
|
|
@ -69,13 +69,15 @@ internal sealed class ChargenPreviewAnimatedBuild
|
|||
/// <b>CC6b:</b> retail's chargen preview does NOT default to a frozen pose —
|
||||
/// <c>gmCGAppearancePage::Update</c>'s own trailing gate
|
||||
/// (~0x0047EF01-0x0047EF12) calls <c>gmCG3DView::StartAnimation</c> (idle
|
||||
/// loop playing) whenever <c>m_bZoomedIn == 0</c>, and that field is never
|
||||
/// explicitly initialized away from its zero-initialized default in the
|
||||
/// ctor (<c>gmCGAppearancePage::gmCGAppearancePage</c>, pseudo-C
|
||||
/// ~0x0047CD58-0x0047CD64 — <c>m_bShouldZoomAnimate</c>/<c>m_bRotating</c>/
|
||||
/// <c>m_bZoomedIn</c> are three consecutive bool bytes the decompiler shows
|
||||
/// only the first two of, a known decompiler-elision class per
|
||||
/// <c>claude-memory/feedback_bn_decomp_field_names.md</c>). So retail's
|
||||
/// loop playing) whenever <c>m_bZoomedIn == 0</c>, and that default is
|
||||
/// DIRECTLY ASSIGNED, not inherited:
|
||||
/// <c>gmCGAppearancePage::InitializePage @0x0047FDD0</c> writes an
|
||||
/// explicit <c>m_bZoomedIn = 0</c> at <c>0x004802C3</c> (right after
|
||||
/// setting the camera to the zoomed-IN per-heritage eye at
|
||||
/// <c>0x00480286-0x0048029E</c> — the null-tween quirk the zoom
|
||||
/// controller's doc records). The earlier elided-ctor-byte argument was
|
||||
/// unsound (heap-new members are indeterminate, not zero) and was
|
||||
/// replaced by this citation at the CC6b-PRE re-review. So retail's
|
||||
/// chargen preview plays its idle loop (<c>m_didAnimation</c>, 30fps) from
|
||||
/// the very first frame; the REST pose (<c>m_didAnimationRest</c>, held
|
||||
/// final frame, this class's pre-CC6b-only behavior) only appears once the
|
||||
|
|
|
|||
|
|
@ -35,7 +35,7 @@ namespace AcDream.Core.Physics;
|
|||
/// live, heavily tested production entity-rendering code with zero relation
|
||||
/// to this preview-only feature, so touching it is out of this slice's
|
||||
/// blast radius by design, not oversight). Tracked as
|
||||
/// <c>docs/ISSUES.md</c> #402 so the follow-up has an owner.
|
||||
/// <c>docs/ISSUES.md</c> #403 so the follow-up has an owner.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
public static class RetailAnimationCyclePlayback
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue