fix(chargen): Campaign CC CC6a review fix round — F1-F12

Addresses the CC6a dual-lens review (architectural PASS with reservations,
retail fidelity PASS with reservations, merge after F1/F2/F3).

F1 (BLOCKING) - AlternateSetup/setupId tested the wrong sentinel (0)
instead of retail's INVALID_DID (0xFFFFFFFF, CharGenState::GetSetupID
@0x005C5B22). A hair style storing that value would have been adopted as
a literal Setup id, nulling Get<Setup> and killing the whole preview.
Fixed both sites with a new InvalidDid constant; added two hand-built
tests plus an installed-DAT sweep of every hair style across all 26
heritage/gender combinations (869 selections, zero unresolved Setup ids).

F2 (BLOCKING) - TS-82's register row, ChargenClothingTable.cs's doc, and
the plan's ledger row all understated Undead's measured clothing-coverage
gap as "headgear/trousers/footwear" (3 slots) with a self-contradicting
"4 of 4 non-shirt slots" aside. Corrected everywhere to the true measured
ALL FOUR slots (headgear, trousers, shirt, footwear).

F3 (BLOCKING) - the palette-math "three independent sources" claim
overcounted: ACViewer's ClothingTableList.xaml.cs:97 computes a different
expression for a different problem, and its vendored PaletteSet.cs is
ACE's own file, not an independent implementation. Rewrote the evidence
paragraph in ChargenPalSetMath.cs to the two sources that actually hold
(decomp control flow + ACE's "Taken from acclient.c" port).

F4 (MEDIUM) - ChargenPreviewEntityBuilder.TryBuild did unlocked dat reads;
DatCollection is not thread-safe and every sibling dat-touching resolver
in this layer takes a shared datLock. Added a required datLock parameter;
every dat read now happens inside one lock, mirroring
RetailPaperdollPoseApplicator.Apply's shape.

F5 (LOW) - noted the pre-existing Streaming.LandblockBuildFactoryTests
timing flake in the ledger so a future session doesn't chase it.

F6 (LOW) - fixed ChargenPreviewCamera.cs's rotation doc, which cited a
nonexistent identifier in a dimensionally-wrong expression; corrected to
retail's actual DoRotation @0x0047CAC7 per-tick formula.

F7 (LOW-MEDIUM) - the TS-82 measurement was WriteLine-only; pinned with
real assertions (zero gaps for the 9 standard heritages, exactly the 4
measured Undead table ids on both genders). Kept the existing env-gated
skip pattern (confirmed house convention).

F8 (LOW) - the inner PalSet-miss loop recorded-and-continued past a miss;
retail's own loop returns immediately on a miss (~0x005A7B32), aborting
every remaining choice in that garment. Changed continue to break; added
a test proving a subsequent present PalSet is correctly not applied.

F9 (LOW) - fixed three dangling <see cref="...Compose"/> doc references
(the method is TryCompose).

F10 (LOW) - the packed (byte)(range/8) narrowing was unchecked; a real
NumColors of 2048 happened to wrap to the correct "whole palette" 0
sentinel by unchecked-cast accident. Replaced with explicit PackOffset/
PackNumColors helpers that document the 2048->0 equivalence deliberately
and throw on any other unrepresentable shape.

F11/F12 (LOW, CC6b scope) - noted in the plan's CC6b row: the second
m_alternateSetupID override source is unmodelled, and a shared
RetailHeldPose helper is worth extracting before a fourth consumer.

Test counts: Core.Tests 4772/1 skip (+5), Content.Tests 147/0 (+1),
App.Tests 5121/6 skips (unchanged; F5's named flake did not reproduce) -
zero failures, full solution Release build green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

tests/AcDream.Content.Tests/CharGen/ChargenAppearanceCatalogInstalledDatTests.cs

@@ -13,19 +13,52 @@ namespace AcDream.Content.Tests.CharGen;
 /// everywhere, mid shade" selection and asserts it resolves with no missing
 /// PalSet or ClothingTable dat ids — the CC6a task's explicit acceptance
 /// bar ("every heritage/gender's default selection resolves to a complete
-/// description with no missing dat ids"). Also records (without asserting
-/// zero — see the class doc on <see cref="ChargenClothingTable"/>'s
-/// deliberate scope cut) how many clothing slots have no
-/// <c>ClothingBaseEffects</c> entry for their own gender's body Setup, so a
-/// future session can see at a glance whether CC6a's decision to skip
-/// retail's Setup-substitution fallback chain ever actually costs
-/// coverage on the real dat.
+/// description with no missing dat ids"). ALSO pins the TS-82 measurement
+/// with real assertions (not WriteLine-only diagnostics, per the CC6a
+/// review fix round F7): the nine standard heritages with clothing UI shown
+/// resolve zero <c>ClothingBaseEffects</c> gaps, and Undead resolves
+/// EXACTLY the four measured gaps on both genders — see the class doc on
+/// <see cref="ChargenClothingTable"/>'s deliberate scope cut.
+///
+/// <para>Env-gated skip (house pattern, matched from
+/// <c>ChargenTableReaderInstalledDatTests</c>/<c>ContentConformanceDats</c>):
+/// returns green with a console SKIP note when no installed dat directory is
+/// configured, rather than a true xUnit Skipped status — no other Content
+/// installed-DAT test in this project uses <c>Assert.Skip</c>, so this stays
+/// consistent with the rest of the suite rather than introducing a new
+/// convention.</para>
 /// </summary>
 public sealed class ChargenAppearanceCatalogInstalledDatTests
 {
     private readonly ITestOutputHelper _out;
     public ChargenAppearanceCatalogInstalledDatTests(ITestOutputHelper output) => _out = output;
 
+    // ACE ACE.Entity.Enum.HeritageGroup ids. Gearknight (6)/Olthoi (12)/
+    // OlthoiAcid (13) are deliberately not named here — see the WriteLine-only
+    // comment in the loop below for why they carry no pinned expectation.
+    private const uint TumerokId = 7u;
+    private const uint UndeadId = 11u;
+
+    /// <summary>
+    /// The 9 standard heritages whose UI actually shows clothing controls
+    /// AND whose default gear resolves with zero <c>ClothingBaseEffects</c>
+    /// gaps (measured, not the full "clothing UI shown" set — Undead is
+    /// ALSO clothing-UI-shown but is the one real gap, asserted separately
+    /// below). Aluvian/Gharu'ndim/Sho/Viamontian/Shadowbound/Tumerok/Lugian/
+    /// Empyrean/Penumbraen = every heritage id 1-10 except Gearknight (6).
+    /// </summary>
+    private static readonly uint[] StandardZeroGapHeritageIds = [1u, 2u, 3u, 4u, 5u, TumerokId, 8u, 9u, 10u];
+
+    /// <summary>
+    /// Measured (installed EoR dat, both genders, identical order): Undead's
+    /// default headgear/trousers/shirt/footwear choices' clothing tables, in
+    /// the factory's own Headgear→Trousers→Shirt→Footwear composition order.
+    /// ALL FOUR slots miss — not "headgear/trousers/footwear" (a three-slot
+    /// undercount an earlier draft of this row stated in error).
+    /// </summary>
+    private static readonly uint[] UndeadMeasuredMissingClothingTableIds =
+        [0x10000009u, 0x100000F9u, 0x10000001u, 0x10000007u];
+
     private static string? ResolveDatDir()
     {
         string? fromEnv = Environment.GetEnvironmentVariable("ACDREAM_DAT_DIR");
@@ -55,8 +88,8 @@ public sealed class ChargenAppearanceCatalogInstalledDatTests
         var catalog = new ChargenAppearanceCatalog(adapter);
 
         int composed = 0;
-        int absentBaseEffectTotal = 0;
         var missingSummaries = new List<string>();
+        var baseEffectGapFailures = new List<string>();
 
         foreach (ChargenHeritageOptions heritage in options.HeritagesById.Values)
         {
@@ -79,23 +112,134 @@ public sealed class ChargenAppearanceCatalogInstalledDatTests
                         + $"missingClothingTables=[{string.Join(",", result.MissingClothingTableIds.Select(id => $"0x{id:X8}"))}]");
                 }
 
-                absentBaseEffectTotal += result.ClothingTablesMissingBaseEffectForSetup.Count;
-                if (result.ClothingTablesMissingBaseEffectForSetup.Count > 0)
+                _out.WriteLine(
+                    $"heritage={heritage.Name} (0x{heritage.HeritageId:X}) gender={genderKey} setup=0x{result.SetupId:X8}: "
+                    + $"{result.ClothingTablesMissingBaseEffectForSetup.Count} clothing table(s) with no "
+                    + "ClothingBaseEffects entry for this body setup "
+                    + $"[{string.Join(",", result.ClothingTablesMissingBaseEffectForSetup.Select(id => $"0x{id:X8}"))}]");
+
+                // TS-82's pinned measurement — real assertions, not WriteLine-only.
+                if (StandardZeroGapHeritageIds.Contains(heritage.HeritageId))
                 {
-                    _out.WriteLine(
-                        $"heritage={heritage.Name} gender={genderKey} setup=0x{result.SetupId:X8}: "
-                        + $"{result.ClothingTablesMissingBaseEffectForSetup.Count} clothing table(s) with no "
-                        + "ClothingBaseEffects entry for this body setup "
-                        + $"[{string.Join(",", result.ClothingTablesMissingBaseEffectForSetup.Select(id => $"0x{id:X8}"))}]");
+                    if (result.ClothingTablesMissingBaseEffectForSetup.Count != 0)
+                    {
+                        baseEffectGapFailures.Add(
+                            $"heritage={heritage.Name} gender={genderKey}: expected ZERO ClothingBaseEffects "
+                            + $"gaps (a standard heritage with clothing UI shown), measured "
+                            + $"{result.ClothingTablesMissingBaseEffectForSetup.Count}: "
+                            + $"[{string.Join(",", result.ClothingTablesMissingBaseEffectForSetup.Select(id => $"0x{id:X8}"))}]");
+                    }
+                }
+                else if (heritage.HeritageId == UndeadId)
+                {
+                    if (!result.ClothingTablesMissingBaseEffectForSetup.SequenceEqual(UndeadMeasuredMissingClothingTableIds))
+                    {
+                        baseEffectGapFailures.Add(
+                            $"heritage=Undead gender={genderKey}: expected EXACTLY "
+                            + $"[{string.Join(",", UndeadMeasuredMissingClothingTableIds.Select(id => $"0x{id:X8}"))}], measured "
+                            + $"[{string.Join(",", result.ClothingTablesMissingBaseEffectForSetup.Select(id => $"0x{id:X8}"))}]");
+                    }
+                }
+                // Gearknight/Olthoi/OlthoiAcid: retail hides the clothing UI
+                // entirely for these three (gmCGAppearancePage::Update
+                // @0x0047E8F0's SetVisible(0) branches), so a real chargen
+                // selection never reaches this composer's clothing slots for
+                // them — no pinned expectation either way, WriteLine above
+                // is diagnostic only.
+            }
+        }
+
+        _out.WriteLine($"composed {composed} heritage/gender selections.");
+        Assert.True(
+            missingSummaries.Count == 0,
+            "Missing dat ids found:\n" + string.Join('\n', missingSummaries));
+        Assert.True(
+            baseEffectGapFailures.Count == 0,
+            "TS-82 measurement drifted from its pinned expectation:\n" + string.Join('\n', baseEffectGapFailures));
+        Assert.True(composed >= 13, $"Expected at least 13 heritage/gender combinations, composed {composed}.");
+    }
+
+    /// <summary>
+    /// CC6a review fix round F1: retail's Setup-id "unset" sentinel is
+    /// <c>INVALID_DID</c> (0xFFFFFFFF), not 0
+    /// (<c>CharGenState::GetSetupID @ 0x005C5B22</c>). Sweeps EVERY hair
+    /// style of all 26 heritage/gender combinations and asserts the composed
+    /// SetupId always resolves to a REAL installed Setup dat entry — proving
+    /// neither sentinel value, wherever a hair style's <c>AlternateSetup</c>
+    /// field happens to store one, ever reaches <c>Get&lt;Setup&gt;</c> as a
+    /// literal id.
+    /// </summary>
+    [Fact]
+    public void EveryHairStyleOfEveryHeritageGender_ComposesToARealInstalledSetupId()
+    {
+        string? datDir = ResolveDatDir();
+        if (datDir is null)
+        {
+            _out.WriteLine("SKIP: installed retail DAT directory is unavailable.");
+            return;
+        }
+
+        using var dats = new DatCollection(datDir, DatAccessType.Read);
+        using var adapter = new DatCollectionAdapter(dats);
+
+        ChargenOptions options = ChargenTableReader.Load(adapter);
+        Assert.NotEmpty(options.HeritagesById);
+        var catalog = new ChargenAppearanceCatalog(adapter);
+
+        int sweptHairStyles = 0;
+        var unresolvedSetups = new List<string>();
+
+        foreach (ChargenHeritageOptions heritage in options.HeritagesById.Values)
+        {
+            foreach ((int genderKey, ChargenGenderOptions gender) in heritage.GendersByKey)
+            {
+                for (uint hairStyleIndex = 0; hairStyleIndex < (uint)gender.HairStyles.Count; hairStyleIndex++)
+                {
+                    ChargenAppearanceSelection selection = ChargenAppearanceSelection.Default with
+                    {
+                        HairStyle = hairStyleIndex,
+                        SkinShade = 0.5,
+                    };
+
+                    bool ok = ChargenAppearanceFactory.TryCompose(
+                        options, heritage.HeritageId, genderKey, selection,
+                        catalog, catalog, out ChargenAppearanceResult result);
+                    Assert.True(ok);
+                    sweptHairStyles++;
+
+                    if (adapter.Get<DatReaderWriter.DBObjs.Setup>(result.SetupId) is null)
+                    {
+                        unresolvedSetups.Add(
+                            $"heritage={heritage.Name} gender={genderKey} hairStyle={hairStyleIndex}: "
+                            + $"composed SetupId=0x{result.SetupId:X8} does not resolve to an installed Setup");
+                    }
+                }
+
+                // Every gender is swept even with zero hair styles (still
+                // exercises the "no hair style selected" default-setup path).
+                if (gender.HairStyles.Count == 0)
+                {
+                    bool ok = ChargenAppearanceFactory.TryCompose(
+                        options, heritage.HeritageId, genderKey,
+                        ChargenAppearanceSelection.Default with { SkinShade = 0.5 },
+                        catalog, catalog, out ChargenAppearanceResult result);
+                    Assert.True(ok);
+                    sweptHairStyles++;
+                    if (adapter.Get<DatReaderWriter.DBObjs.Setup>(result.SetupId) is null)
+                    {
+                        unresolvedSetups.Add(
+                            $"heritage={heritage.Name} gender={genderKey} (no hair styles): "
+                            + $"composed SetupId=0x{result.SetupId:X8} does not resolve to an installed Setup");
+                    }
                 }
             }
         }
 
-        _out.WriteLine($"composed {composed} heritage/gender selections; {absentBaseEffectTotal} absent-base-effect slots total.");
+        _out.WriteLine($"swept {sweptHairStyles} hair-style/no-hair-style selections across 26 heritage/gender combinations.");
         Assert.True(
-            missingSummaries.Count == 0,
-            "Missing dat ids found:\n" + string.Join('\n', missingSummaries));
-        Assert.True(composed >= 13, $"Expected at least 13 heritage/gender combinations, composed {composed}.");
+            unresolvedSetups.Count == 0,
+            "Composed SetupId(s) that don't resolve to a real installed Setup:\n" + string.Join('\n', unresolvedSetups));
+        Assert.True(sweptHairStyles > 26, $"Expected more than 26 swept selections (multiple hair styles per gender), got {sweptHairStyles}.");
     }
 
     /// <summary>