feat(chat): Campaign CH slice CH1 — retail LogTextType color table
Retail colors chat lines by the 34-value wire LogTextType (ACE's ChatMessageType), NOT by acdream's synthetic 9-value ChatKind. The old ChatWindowController.RetailChatColor(ChatKind) collapsed distinct retail colors onto one bucket per ChatKind — e.g. every Channel line rendered colorLightBlue (Magic's slot) when retail's actual palette spans five different colors across the Turbine rooms and legacy allegiance family. Ports ChatInterface::BuildChatColorLookupTable @0x004F31C0 verbatim (RetailChatColorTable, all 34 RGBA floats read from the PDB-paired binary's .data section) and threads a new ChatEntry.LogTextType field through every ingestion site to the correct retail wire value: HearSpeech/Tell pass the wire chatType through verbatim; Emote/SoulEmote hard-code 0x0C; the Tell self-echo hard-codes 0x04; legacy ChatChannel broadcasts derive their type from the channel bit via the new LegacyChannelChatType helper (ported from the decompiled Handle_Communication__ChannelBroadcast dispatch, hear vs. own-send); TurbineChat rooms map through TurbineChatDisplayNames.LogTextType; CombatChatTranslator's hit/miss/evade lines map to ACE's CombatSelf/ CombatEnemy per Player_Combat.cs; kill/death lines use retail's decompiled 0x00 Default (not a combat color). ChatWindowController's transcript now folds LogTextType through RetailChatColorTable with retail's exact "out-of-range keeps the previous line's color" carry rule; ChatPanel's combat highlighting sources the same table. Corrects HearSpeech.cs's doc-comment ChatType legend (4 of 6 entries were wrong). Adds register row AP-175 for the pre-existing (unchanged) Popup-renders-in-chat divergence and updates AP-39's stale per-ChatKind description. Narrows ISSUES #139 — its chat-colors half is done. Retail renders no chat timestamp prefix path exists in acdream today, so the "timestamp is always colorGrey 0x0C" rule has nothing to attach to; noted here per the research doc rather than left silent. Research: docs/research/2026-08-09-chat-retail-color-table.md Full Release suite: 11,833 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
8df35d1e18
commit
172c6f9aa3
26 changed files with 1360 additions and 85 deletions
|
|
@ -112,7 +112,13 @@ public sealed class ChatVM : IDisposable
|
|||
/// client-handled commands (/help, /clear, future) to surface
|
||||
/// local feedback without round-tripping the server.
|
||||
/// </summary>
|
||||
public void ShowSystemMessage(string text) => _log.OnSystemMessage(text, chatType: 0);
|
||||
/// <remarks>
|
||||
/// LogTextType <c>0x1A</c>: this text never reaches the wire — the
|
||||
/// same "client-local text" category as retail's own command-parser
|
||||
/// errors and <c>cant_jump_*</c> strings (research doc
|
||||
/// <c>docs/research/2026-08-09-chat-retail-color-table.md</c> §2.2).
|
||||
/// </remarks>
|
||||
public void ShowSystemMessage(string text) => _log.OnSystemMessage(text, chatType: 0x1Au);
|
||||
|
||||
/// <summary>
|
||||
/// Drain the chat log. Used by the /clear client-side command.
|
||||
|
|
@ -256,7 +262,9 @@ public sealed class ChatVM : IDisposable
|
|||
/// <see cref="ChatPanel"/> can pick the right rendering primitive
|
||||
/// per entry (plain <c>Text</c> for most kinds; <c>TextColored</c>
|
||||
/// for combat lines, with the rgba chosen from
|
||||
/// <see cref="ChatEntry.CombatKind"/>).
|
||||
/// <see cref="ChatEntry.CombatKind"/>). Campaign CH slice CH1 also
|
||||
/// carries <see cref="ChatEntry.LogTextType"/> through — the retail
|
||||
/// color key, keyed independently of <see cref="ChatKind"/>.
|
||||
/// </summary>
|
||||
public IReadOnlyList<FormattedLine> RecentLinesDetailed()
|
||||
{
|
||||
|
|
@ -272,7 +280,8 @@ public sealed class ChatVM : IDisposable
|
|||
lines[i] = new FormattedLine(
|
||||
Text: FormatEntry(entry),
|
||||
Kind: entry.Kind,
|
||||
CombatKind: entry.CombatKind);
|
||||
CombatKind: entry.CombatKind,
|
||||
LogTextType: entry.LogTextType);
|
||||
}
|
||||
return lines;
|
||||
}
|
||||
|
|
@ -284,7 +293,12 @@ public sealed class ChatVM : IDisposable
|
|||
/// <see cref="CombatKind"/> to pick a rendering primitive
|
||||
/// (<c>Text</c> vs <c>TextColored(rgba)</c>).
|
||||
/// </summary>
|
||||
/// <param name="LogTextType">
|
||||
/// Campaign CH slice CH1: the retail wire <c>LogTextType</c> that keys
|
||||
/// <see cref="RetailChatColorTable"/> — see <see cref="ChatEntry.LogTextType"/>.
|
||||
/// </param>
|
||||
public readonly record struct FormattedLine(
|
||||
string Text,
|
||||
ChatKind Kind,
|
||||
CombatLineKind? CombatKind);
|
||||
CombatLineKind? CombatKind,
|
||||
uint LogTextType);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue