erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

Merge branch 'main' into claude/latest-commits-cb0c8f

Browse source 
# Conflicts:
#	tests/AcDream.App.Tests/Streaming/LandblockBuildOriginTests.cs
This commit is contained in:
Erik 2026-08-14 12:52:34 +02:00
commit 1528e5693b
2 changed files with 33 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

24
docs/ISSUES.md
View file

@ -1750,11 +1750,25 @@ session; the live gate covered the behavior.
## #351 — LandblockBuildOriginTests.FarLoad_StripsEnvCellsAndPhysics flake (Debug, load-sensitive) ## #351 — LandblockBuildOriginTests.FarLoad_StripsEnvCellsAndPhysics flake (Debug, load-sensitive)
**Status:** OPEN (filed 2026-08-08). Seen three times today in Debug runs **Status:** CLOSED 2026-08-09 (`c6bc2bf7`). NOT a flake and NOT timing —
under parallel-agent load (5.4 implementer, Slice 6 corrections, dropdown the "load-sensitive" framing was wrong: it failed deterministically on
polish), each time proven pre-existing by re-running against the pristine EVERY Debug `dotnet test` run since the test landed (`090b0354`
base commit; never reproduces in clean-room Release. An async streaming introduced the test and the tripwire in the same commit; the
timing assumption most likely; deflake when it next blocks a verdict. parallel-agent-load correlation was just that Debug runs are rare — the
gate config is Release). Mechanism: the test feeds a far-tier factory
returning Near payload on purpose to prove the strip safety net, but
`LandblockStreamer.HandleJob` is documented "fail loud in Debug builds
and strip in Release" — its `Debug.Assert` fires on exactly that input,
the VSTest host translates the assert into a thrown
`DebugAssertException` (its message says so verbatim) instead of killing
the testhost, and the worker catch folds it into a `Failed` completion,
so `Assert.IsType<Loaded>` fails. Release compiles the assert out
(`[Conditional("DEBUG")]`) and strips — hence "never reproduces in
clean-room Release". Fix: the test now pins BOTH halves of the
config-divergent contract via `#if DEBUG` (Debug expects the loud
`Failed` carrying the assert text; Release keeps the strip assertions).
Production code unchanged; LandblockBuildOriginTests 11/11 in both
configs.
## #350 — Render-shadow ledger overflow after 2h42m: lifetime int counters in a never-reset accumulator ## #350 — Render-shadow ledger overflow after 2h42m: lifetime int counters in a never-reset accumulator

28
tests/AcDream.App.Tests/Streaming/LandblockBuildOriginTests.cs
View file

@ -221,23 +221,23 @@ public sealed class LandblockBuildOriginTests
origin)); origin));
streamer.Start(); streamer.Start();
LandblockStreamResult result = await DrainFirstAsync(streamer);
#if DEBUG #if DEBUG
// LandblockStreamer.HandleJob's near-payload check is "fail loud in // The near-payload tripwire is config-divergent by design ("fail loud
// Debug builds and strip in Release" (its own comment): the // in Debug builds and strip in Release" — LandblockStreamer.HandleJob):
// Debug.Assert fires on this deliberately-buggy factory, the test // in Debug the Debug.Assert fires and the VSTest host translates it
// host's trace listener turns it into an exception, and the job's // into a thrown DebugAssertException, which the worker's catch folds
// catch-all publishes it as Failed. That IS the designed Debug // into a Failed completion (#351).
// outcome — this test previously asserted the Release strip var failed = Assert.IsType<LandblockStreamResult.Failed>(
// unconditionally and so failed on every full Debug run await DrainFirstAsync(streamer));
// (found 2026-08-13; the campaign gates all run Release).
var failed = Assert.IsType<LandblockStreamResult.Failed>(result); Assert.Contains(
Assert.Equal(landblockId, failed.LandblockId); "Far-tier factory returned Near payload",
failed.Error,
StringComparison.Ordinal);
Assert.Equal(84ul, failed.Generation); Assert.Equal(84ul, failed.Generation);
Assert.Contains("Far-tier factory returned Near payload", failed.Error);
#else #else
var loaded = Assert.IsType<LandblockStreamResult.Loaded>(result); var loaded = Assert.IsType<LandblockStreamResult.Loaded>(
await DrainFirstAsync(streamer));
Assert.Equal(LandblockStreamTier.Far, loaded.Tier); Assert.Equal(LandblockStreamTier.Far, loaded.Tier);
Assert.Empty(loaded.Landblock.Entities); Assert.Empty(loaded.Landblock.Entities);