erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

chore: secure-trade closeout - strip [trade] gate probes, roadmap ledger

Browse source 
The two-client user gate PASSED 2026-08-14 (open both ways, stage with
the retail trading marker, accept/decline, executed swap, Clear All,
cancel text). Every TEMPORARY [trade] probe line from gate rounds 1-2 is
stripped (ItemInteractionController, SelectionInteractionController,
SecureTradeUiController, LiveSessionCommandRouter, WorldSession,
RuntimeTradeState). Roadmap gains the shipped-trade ledger row.

Suites after strip: App 4,992/3, Runtime 1,626 - green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-14 12:48:31 +02:00
parent be3e617a2b
commit 0f15c74147
7 changed files with 3 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/AcDream.App/UI/ItemInteractionController.cs
View file

@ -1055,19 +1055,11 @@ public sealed class ItemInteractionController : IDisposable
& PublicWeenieFlags.Player) == 0)
return false;
if (PhysicsDiagnosticsTradeProbe)
Console.WriteLine(
$"[trade] use-on-player guid=0x{targetGuid:X8} "
+ $"nonCombat={_inNonCombatMode()} subscribers={SecureTradeRequested is not null}");
if (_inNonCombatMode())
SecureTradeRequested?.Invoke(targetGuid, 0u);
return true;
}
/// <summary>TEMPORARY (2026-08-14 trade gate round 1): [trade] seam
/// probe lines, stripped once the two-client gate passes.</summary>
internal static bool PhysicsDiagnosticsTradeProbe = true;
public bool DropToWorld(ItemDragPayload payload)
=> PlaceIn3D(payload, targetGuid: 0u);
@ -1219,10 +1211,6 @@ public sealed class ItemInteractionController : IDisposable
// (ItemHolder::AttemptPlaceIn3D @ 0x00588600's option branch
// → ClientTradeSystem::AttemptToTradeItem @ 0x0056DF80).
// ObjectId = the dragged item, TargetId = the player.
if (PhysicsDiagnosticsTradeProbe)
Console.WriteLine(
$"[trade] drag-on-player item=0x{action.ObjectId:X8} "
+ $"target=0x{action.TargetId:X8} subscribers={SecureTradeRequested is not null}");
SecureTradeRequested?.Invoke(action.TargetId, action.ObjectId);
break;
case ItemPolicyActionKind.DropToWorld: