fix #435 (part 1): delete 17 probes that outlived their closed investigations
Each of these was temporary apparatus added to chase one bug, and each was supposed to be deleted in the commit that fixed it. Fourteen closed issues later they were still here: #337's support/wire-mesh trio, #171's sticky timeline, #119's viewer and entity dumps, #113's phantom probe, and a dozen more. 3,493 lines removed; the client now reads 144 environment variables instead of 161, and 47 temporary probes remain instead of 64. This is not only tidying. Every probe leaves a branch on its hot path when unset, several re-read the environment per call rather than caching, and the volume buries the diagnostics that are actually load-bearing. It is also a headless correctness matter: HeadlessStaticStateAudit reflects over PhysicsDiagnostics' flags to refuse a multi-session host when any is set, and cannot see probes that live outside that owner. Four files went entirely — WalkMissDiagnostic.cs, CollisionMeshWireframe.cs and two test files whose only subject was a deleted probe. TransitionTypes.SetContactPlane also sheds its CallerMemberName / CallerLineNumber parameters, which existed solely for #337's cpSrc= attribution and carried the instruction to strip them with the probe family; no call site passed them, so no behavior changes. F2's collision overlay survives and reverts to its proxy-cylinder form, which is what removing the ACDREAM_WIRE_MESH upgrade means. LaunchOptionsDocumentationTests earned its keep here: it refused the deletion until docs/launch-options.md moved the 17 rows into Retired and the frozen direct-read counts came down (PhysicsEngine.cs to zero, TransitionTypes.cs 3 to 2). The documentation could not drift during a cleanup this wide. The 14 probes that name no owning issue are deliberately NOT deleted. Nothing records when they became safe to remove, and guessing is how a future investigation loses apparatus it needed; #435 stays open for their attribution. Full hermetic suite 15,321 passed / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
05bfe8d162
commit
0c5057c9ff
34 changed files with 57 additions and 3495 deletions
|
|
@ -137,12 +137,8 @@ public sealed class TransitFailProbeTests
|
|||
|
||||
string log = sw.ToString();
|
||||
|
||||
// The probe's own families must be completely silent on a healthy
|
||||
// moving tick. (Console.Out may still carry unrelated one-shot
|
||||
// process diagnostics — e.g. the #338 AnnounceStepHeightProbeOnce
|
||||
// self-report, which fires unconditionally on the first IsPlayer
|
||||
// resolve in the process regardless of any flag — so this checks
|
||||
// the probe's own tag rather than asserting total silence.)
|
||||
// The probe's own family must be completely silent on a healthy
|
||||
// moving tick.
|
||||
Assert.DoesNotContain("[transit-fail", log);
|
||||
|
||||
float actualDy = result.Position.Y - 0.00f;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue