Finish bounded lighting-observer cleanup and record verification

This commit is contained in:
Erik 2026-09-05 15:15:59 +02:00
parent 2f192570a2
commit 0ae2666ef0
11 changed files with 70 additions and 582 deletions

View file

@ -1,6 +1,8 @@
# #478 temporary lighting observer removal
ACTIVE after candidatea5debaca2: unchanged Town High/off/High and0125/8C04
IMPLEMENTED and lead-reviewed at scratch ed2c8b12c; integration's fresh Release
and final graphical repeat are pending. See `478-observer-removal-verification.md`.
Activated after candidatea5debaca2: unchanged Town High/off/High and0125/8C04
control PNGs inspected, eight provisional lighting/reveal PASS frames,
`478-repaired-lighting-graphical.md`. Both own clients exited0/gracefully.
This is not owner acceptance. A failed final visual check returns to

View file

@ -0,0 +1,51 @@
# #478 observer removal — lead verification
The eight candidate PNGs at `a5debaca2` passed the narrow lighting/reveal
smoke provisionally (`478-repaired-lighting-graphical.md`). Under
`478-observer-removal-contract.md`, OpenAI James removed only the temporary
observer and its corresponding tests. Lead committed scratch
`ed2c8b12c1ecd31dbc0069419db8104ed0e2bd49`, base `1772c1a5a`, and verified
the six retained integration blobs against that commit; the seventh path is
the deleted `EnvCellRenderer.LightingObservation.cs`.
## Scope review
Exactly seven paths, 1 insertion / 581 deletions. No lighting selection,
ambient, shader, generated module, package, geometry or FPS changes. Four
composition/DTO/test files restore the exact pre-observer (`59b0b6e72^`) Git
blobs; snapshot-source restoration differs only by one blank line. Remaining
EnvCell test changes remove only observer tests and unused helpers/imports.
The permanent two-cell 47-index RHI upload and next-generation overwrite test,
its required helpers, ordinary 8-index upload and both compiled shader pixel
witnesses remain. Observer symbol search over `src` and `tests` returns none.
Unrelated lifecycle and current-render-scene checkpoint evidence remains.
Lead checked the complete diff and all six raw source hashes against the
frozen implementer return. No new retail algorithm or deviation is introduced;
the preceding independent retail and production/ABI reviews still cover the
unchanged repair. No additional retail re-port or review round was needed.
The removed temporary source remains recoverable from Git history.
## Verification before integration
Artifacts under scratch `s5-478-observer-cleanup/artifacts/478-observer-cleanup/`:
- `release-build-r2/console.log`: full solution Release, 0 warnings/errors.
First build caught a removed Wb import also needed by `GpuMemoryTracker`;
that import was restored before the final build and freeze.
- `app-focused/app-focused.trx`: 180/180 affected/permanent tests.
- `core-lighting/core-lighting.trx`: 69/69, including installed Town DAT.
- `shader-pixels/shader-pixels.trx`: both committed-module witnesses pass.
- Lead independent `root-removal/root-removal.trx`: 106/106 affected
lifecycle/composition/EnvCell/ordinary-upload tests plus both native pixels.
Lead inspected actual build output and all TRX counters. Both client names
were absent before the independent execution. These are focused correctness
tests, not the full solution test lane or an FPS benchmark.
## Final graphical gate
Pending fresh Release on the integrated observer-free commit and the unchanged
Town High/off/High plus 0125/8C04/Holtburg control routes. Candidate consumed-
light measurements remain evidence only for `a5debaca2`, not for this binary.
Owner acceptance remains owed; G4 FAIL/unpassed, no main merge. FPS deferred.

View file

@ -4982,3 +4982,11 @@ requested but its live module check missed the already-exited process; no
stronger claim. `478-repaired-lighting-graphical.md` seals paths/hashes/limits.
Observer removal contract activated; final observer-free re-gate still owed.
No FPS work, no owner acceptance, G4FAIL/no main merge.
Observer cleanup reviewed and integrated from scratch `ed2c8b12c`: exactly
seven paths, temporary capture/DTO/wiring and observer-only tests removed.
Permanent RHI47/ordinary8/native-pixel coverage retained; six retained blobs
match. Full scratch Release0W0E, App180/Core69/native2 PASS; lead independent
affected/native106/106. `478-observer-removal-verification.md` records scope
and actual reports. No new deviation, retail algorithm or FPS edit. Fresh
integrated Release and unchanged final graphical repeats remain next.