erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: Campaign OP CODE-COMPLETE — plan/script/CLAUDE.md status flips

Browse source 
The campaign's /goal stop condition is reached: all nine slices landed and
reviewed (OP1/OP2/OP7/OP9 CLOSED; OP3-OP6 + OP8 code-complete with
connected gates owed), and the gate script is the complete per-tab
connected-gate contract (launch with ACDREAM_RETAIL_UI=1; §OP7 already
PASSED live bot-vs-ACE). OP9's ledger row records the combined review
chain (289bf5bc APPROVE-WITH-FIXES -> residuals 07f2b3f7) including
SF-4's corrected test-delta arithmetic (-84, not the implementation
commit's '-80 exactly'). CLAUDE.md Current-state gains the campaign
paragraph per feedback_claude_md_staleness; the settings digest
(claude-memory/project_settings_options_digest.md) is the new domain
entry point.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-11 13:43:33 +02:00
parent 07f2b3f72e
commit 07c0c2c7b9
3 changed files with 32 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docs/plans/2026-08-10-options-panel-campaign.md
View file

@ -6,7 +6,11 @@
> appendix — implementers MUST read the cited sections before coding; every
> table this plan references by section number is committed there in full.
**Status: ACTIVE — planned 2026-08-10. No slices landed yet.**
**Status: CODE-COMPLETE 2026-08-11 — all nine slices landed and reviewed.
OP1/OP2/OP7/OP9 CLOSED; OP3–OP6 + OP8 owe their connected user gates (the
campaign's remaining work is the user's eyes, not code). Gate script:
`docs/research/2026-08-11-campaign-op-test-script.md`. Post-campaign tail:
#371, #372's Gameplay-buttons re-gate observation, #373, AP-198/199/201/202/203.**
**Goal:** retail's four-tab in-game Options panel (Gameplay Options /
Character / Chat / Config), retail-faithful mechanics end-to-end: authored
@ -425,4 +429,4 @@ before anything builds on them.
| OP6 | CODE-COMPLETE, gate READY | `f5ac1742` (REJECTED) → rework `472525b9` → doc residuals (coordinator) | REJECT (`2026-08-11-op6-review.md`) → re-review CLOSED, all six caption sites byte-decoded (`2026-08-11-op6-rereview.md`) | connected gate OWED (script §OP6) |
| OP7 | CLOSED | `09cb548a` → fixes in `7b60e71b` (shared commit, see its message) | combined-lens APPROVE-WITH-FIXES (`2026-08-11-op7-review.md`); all nine findings closed | live bot-vs-ACE gate PASSED 2026-08-11 (coordinator; evidence in script §OP7) |
| OP8 | CODE-COMPLETE, gate READY | `b4edee97` (REJECTED) → rework `b1968ce9` → residuals `f1d50207` → merge `1c5cd969` | dual REJECT (`2026-08-11-op8-review-{mechanism,blast}.md`) → rework → re-review REOPEN-narrow (`2026-08-11-op8-rereview.md`) → coordinator round-2 residuals (inert-row conflict exclusion, DAT-default display, injectivity pin; #373 filed) | connected gate OWED (script §OP8) — merged onto the campaign tip AFTER `057d8cd7` per the re-review's merge note, so the #372 viewport fix covers OP8's six ListBoxes |
| OP9 | — | | | |
| OP9 | CLOSED | `371197a3` → review residuals `07f2b3f7` | combined-lens APPROVE-WITH-FIXES (`2026-08-11-op9-review.md`, `289bf5bc`): MUST-FIX 1 (SaveAudio→ApplyAudio live-apply lost its only assertion — restored + failure-ordering pin), SF-2 (code-structure.md seam list), SF-3 (dead residues: private SaveCharacter, ISettingsStorage.SaveCharacter, IngressShutdownRoots.Settings — deleted; SettingsStore's public SaveCharacter kept as the tested storage API), SF-4 (test-delta was −84 = 94 removed/10 added, not the commit message's "−80 exactly"; no live-behavior test in the gap besides MUST-FIX 1's), SF-5 (dangling comment), NIT 6 (AP-196 channel attribution corrected in-register) — all closed by coordinator residuals | closeout gate = the user's final connected matrix over §OP3–§OP8 |

10
docs/research/2026-08-11-campaign-op-test-script.md
View file

@ -1,7 +1,13 @@
# Campaign OP connected-gate test script
**Status:** OP3, OP4, OP5, OP6, OP7, and OP8 sections. The campaign's OP9
closeout gate is this document complete plus every slice code-complete.
**Status: COMPLETE (2026-08-11) — the campaign is code-complete and this
script is its connected-gate contract.** §OP3–§OP6 and §OP8 are the gates
the user still owes their eyes; §OP7's gate already PASSED (coordinator,
evidence in-section). Launch with `ACDREAM_RETAIL_UI=1` against live ACE.
Re-gate note for the previously-blank tabs: #372's viewport fix landed
(`057d8cd7`), and every wired Gameplay-tab button now logs
`[options] gameplay button 0x... clicked` — a silent click in that log IS
evidence, report it per-button.
This document is the script the user runs against the live connected
client (`ACDREAM_LIVE=1` against the local ACE server) to accept each